feat: Added partition commands #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
AncientPatata
force-pushed
the
ad/add_partition_commands
branch
2 times, most recently
from
88d9ca9 to
7547ed5
Compare
AncientPatata
force-pushed
the
ad/add_partition_commands
branch
from
7547ed5 to
5eb1535
Compare
qdelamea-aneo
requested changes
Jan 15, 2025
Comment on lines
+39
to
+40
| elif isinstance(obj, RepeatedScalarContainer): | ||
| return list(obj) |
There was a problem hiding this comment.
This means that the API doesn't do its job correctly! I would like you to fix the API so that the RepeatedScalarContainer (that is a gRPC ugly object) is converted to a the corresponding python object. Check the to_message function of the Partition class.
AncientPatata
force-pushed
the
ad/add_partition_commands
branch
2 times, most recently
from
a31d887 to
2364331
Compare
AncientPatata
force-pushed
the
ad/add_partition_commands
branch
from
2364331 to
733747a
Compare
qdelamea-aneo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current version of the CLI doesn't have partition-specific commands.
Description
Added commands for :
Testing
Unit tests for the serialization and commandline argument parsing.
Impact
Not applicable.
Additional Information
Will be in draft until Tasks is merged (for sorting)
Checklist