Skip to content

Commit

Permalink
Prohibit methods that can leak data
Browse files Browse the repository at this point in the history
seq_join won't be happy with them anymore
  • Loading branch information
akoshelev committed Jan 19, 2024
1 parent 61d8560 commit 105c76a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .clippy.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@
disallowed-methods = [
{ path = "futures::future::join_all", reason = "We don't have a replacement for this method yet. Consider extending `SeqJoin` trait." },
{ path = "futures::future::try_join_all", reason = "Use Context.try_join instead." },
{ path = "std::boxed::Box::leak", reason = "Not running the destructors on futures created inside seq_join module will cause UB in IPA. Make sure you don't leak any of those." },
{ path = "std::mem::forget", reason = "Not running the destructors on futures created inside seq_join module will cause UB in IPA. Make sure you don't leak any of those." },
{ path = "std::mem::ManuallyDrop::new", reason = "Not running the destructors on futures created inside seq_join module will cause UB in IPA. Make sure you don't leak any of those." },
{ path = "std::vec::Vec::leak", reason = "Not running the destructors on futures created inside seq_join module will cause UB in IPA. Make sure you don't leak any of those." },
]

0 comments on commit 105c76a

Please sign in to comment.