Remove binary files from the released crates.io version #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `well_known_types.bin` file from the crates.io release. Instead of bundling and parsing this file at runtime this commit hard codes the parsed data structure as rust code. This hopefully makes it easier to inspect the generated code.
|
I'm not sure what's required to address the CI failure: https://github.com/andrewhickman/prost-reflect/actions/runs/12395316726/job/34609572295?pr=138 On the first look that one seems to be unrelated to the changes in this PR |
|
@andrewhickman Any chance that you have a look at this? |
|
Thanks for the PR, I'll push a patch release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
well_known_types.binfile from the crates.io release. Instead of bundling and parsing this file at runtime this commit hard codes the parsed data structure as rust code. This hopefully makes it easier to inspect the generated code.Fixes #137