Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HarViewer does not give parsing error with the modification. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prongs
Copy link

@prongs prongs commented Mar 1, 2013

harviewer gives error when a har generated by pcap2har(example) is fed to it(example, see error in console).

After the modification, new har file and the harviewer output.

@andrewf
Copy link
Owner

andrewf commented Mar 5, 2013

Thanks, but pcap2har can't unconditionally add a jsonp call, especially with a hard-coded string. The original HAR works fine in the original HAR Viewer (when you disable validation, due to a long-standing minor bug w.r.t timing). A command-line option would be fine.

@andrewf andrewf closed this Mar 5, 2013
@andrewf andrewf reopened this Mar 5, 2013
@prongs
Copy link
Author

prongs commented Mar 5, 2013

So you want me to add a command line option to check whether or not to add these lines?

@andrewf
Copy link
Owner

andrewf commented Mar 5, 2013

Um, yes, if you think it's important. I would prefer the jsonp function name itself to be configurable too. I hate to throw a bunch of extra requirements at you, but this is a weird use case and, well, I'm picky.

Actually, I was just able to manually upload your original non-jsonp file to pcapperf without any problem, after downloading it to my hdd. Might it be a bug in pcapperf or the HAR viewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants