Support importing multiple versions of the "same" key #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typical use case being GitHub App key rotations. Note that the `import_app_key` method now requires additional Vault permissions, if you want to be able to take advantage of the new versions support. Otherwise the API is fully backward compatible, with the `issue_access_token` method defaulting to using the latest key version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typical use case being GitHub App key rotations.
Note that the
import_app_keymethod now requires additional Vault permissions, if you want to be able to take advantage of the new versions support.Otherwise the API is fully backward compatible, with the
issue_access_tokenmethod defaulting to using the latest key version.