Skip to content
This repository has been archived by the owner on Aug 7, 2018. It is now read-only.

#22 Twitter service #53

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

#22 Twitter service #53

wants to merge 15 commits into from

Conversation

Joerg-Seitz
Copy link
Collaborator

Tests kommen später.. vielleicht sollten wir mal n bisschen diskutieren was wir eigentlich darstellen wollen..... also nur die bilder/die ganzen Tweets etc..

@andreasknoepfle
Copy link
Owner

can u rebase this to the current master :P impossible to read

@codecov-io
Copy link

codecov-io commented Mar 6, 2017

Codecov Report

Merging #53 into master will decrease coverage by 9.25%.
The diff coverage is 40.9%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage     100%   90.74%   -9.26%     
==========================================
  Files          22       21       -1     
  Lines         279      281       +2     
==========================================
- Hits          279      255      -24     
- Misses          0       26      +26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a4696...b190039. Read the comment docs.

@Joerg-Seitz
Copy link
Collaborator Author

well ähm.. i did something with rebase please check it out... ^^

@andreasknoepfle
Copy link
Owner

guess we need to talk about rebasing PRs soon :P

@Joerg-Seitz
Copy link
Collaborator Author

Joerg-Seitz commented Mar 8, 2017

mhm.. just to clarify:
X is das wo ich dran arbeite

       X
      /
A---B---C    
        

das soll zu dem werden richtig?


          X
         /
A---B---C


soll ich die ganzen commits auch squashen?

@andreasknoepfle
Copy link
Owner

The build is failing completely

.to include('puppy')
end
end
end
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this specs look good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants