Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed corrupted svg not loading at Open summer of code #411

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

rishabh7923
Copy link
Contributor

This pull request includes updates to the OsocWidget to improve the handling of SVG images and enhance the UI. The most important changes involve adding a new dependency, updating the widget to use a new SVG handling package, and making UI adjustments.

Dependency Updates:

Widget Updates:

  • lib/widgets/osoc_widget.dart: Imported the jovial_svg package.
  • lib/widgets/osoc_widget.dart: Updated the OsocWidget to use ScalableImageWidget from jovial_svg for displaying SVG images, replacing the previous SvgPicture.network implementation. This includes wrapping the image in a ClipRRect with rounded corners and setting fixed dimensions.

Screenshot

Record_2024-11-10-09-22-01.mp4

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible.

@rishabh7923
Copy link
Contributor Author

@andoriyaprashant

@andoriyaprashant andoriyaprashant merged commit f189ad5 into andoriyaprashant:main Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants