Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Added Application and Contribution periods for the GSSoC '24 Extd Program #331

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

yehiarasheed
Copy link
Contributor

(feat) Added Application and Contribution periods for the GSSoC '24 Extd Program

Problem / Issue No.

Closes issue #330

Describe Problem / Root Cause

The problem is that this project takes part of GSSoC '24 Extd program yet does not have it listed under the Open-Source Timeline of 2024 section of the app.

Solution proposed

In my code, I have added a total of two sections for the GSSoC program, one for the application period and the other for the contribution period. I have clearly listed my sources in the issue, refer to them as needed.

Note

As previously mentioned in the issue, I am a GSSoC '24 Extd and hacktoberfest contributor, so please add both labels to the issue, pull request and project.

Screenshots

  • Original Screenshot (Problem/Issue)
    image

  • Updated Screenshot (Fixes/Solution)
    image

Copy link

github-actions bot commented Oct 6, 2024

Thank you for submitting your pull request! We'll review it as soon as possible.

@andoriyaprashant
Copy link
Owner

@yehiarasheed For GSSoC-Ext, don't create two separate blocks. Just include the start date and end date

@yehiarasheed
Copy link
Contributor Author

yehiarasheed commented Oct 6, 2024

Alright, how would you suggest I proceed? Should I just combine the application period and dates with the contribution period and dates in the same block? I initially separated them for better visibility, so users could easily distinguish the two while knowing it's the same program. This way, the block sizes would match the programs listed above for consistency. What do you think?

image

Please add the hacktoberfest-accepted label to this PR as well to match the hacktoberfest instructions as could be seen above.

@yehiarasheed
Copy link
Contributor Author

image
I have tried it out by merging the two blocks into one, with this solution we still wouldn't leave out information about the program. Although I do think it is really inefficient since now I would mark the start date as the application start date and the end date as the date of the end of the contribution period which would be confusing to the users as to whether the application period is still open or not (defies the whole point of having a feature to turn blocks that are valid orange and invalid blocks to grey)

@andoriyaprashant andoriyaprashant merged commit c63c17a into andoriyaprashant:main Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants