Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #180 resolved #194

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Issue #180 resolved #194

merged 7 commits into from
Jun 10, 2024

Conversation

Shubham-Zone
Copy link
Contributor

@Shubham-Zone Shubham-Zone commented Jun 9, 2024 •
edited
Loading

Problem / Issue No.

Describe Problem / Root Cause

  • The screen contained multiple nested ScrollViews, causing conflicting scroll behaviors. This made it difficult for the user to scroll through the entire screen smoothly, leading to a poor user experience. The primary ScrollView was not functioning correctly due to interference from the nested scrollable widgets.

Solution Proposed

  • The solution involved setting the physics property of the nested ListView widgets to NeverScrollableScrollPhysics(). This ensures that these ListViews do not handle any scroll events, allowing the primary ScrollView to manage scrolling for the entire screen. This change prevents conflicts between the scrollable widgets and ensures a smooth scrolling experience for the user.

Code Changes:

ListView(
  physics: NeverScrollableScrollPhysics(),
  //...
)

Additional Information

  • This solution was applied to all nested ListView widgets within the screen. By making these ListViews non-scrollable, the primary ScrollView can properly handle all scrolling, resulting in a smoother user experience.

Video of changes

WhatsApp.Video.2024-06-10.at.1.26.13.AM.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Thank you for submitting your pull request! We'll review it as soon as possible.

@Shubham-Zone
Copy link
Contributor Author

@andoriyaprashant i have created a PR. this issue is fixed please merge and close the issue

@andoriyaprashant
Copy link
Owner

@Shubham-Zone Remove unnecessary code files

@Shubham-Zone
Copy link
Contributor Author

@andoriyaprashant i have removed all the unnecessary code files

@andoriyaprashant andoriyaprashant merged commit f4ff1eb into andoriyaprashant:main Jun 10, 2024
1 of 2 checks passed
@RishavKumarSinha
Copy link
Contributor

@andoriyaprashant , the changes done in this pull request causes the projects in the Summer of Bitcoin and GSSoC Page to be unscrollable as
physics: NeverScrollableScrollPhysics(),
is applied to the widget _buildProjectList thus effectively stopping the users from accessing any more projects than shown on the front screen.

vijaymehrotra added a commit to vijaymehrotra/OpSo that referenced this pull request Jun 16, 2024
@vijaymehrotra
Squashed commit of the following:
fcfeea6 
commit f4ff1eb
Merge: f46dccd 5a5845a
Author: Prashant Andoriya <[email protected]>
Date:   Mon Jun 10 20:59:20 2024 +0530

    Merge pull request andoriyaprashant#194 from Shubham-Zone/main

    Issue andoriyaprashant#180 resolved

commit f46dccd
Merge: d12b89c 902b3b1
Author: Prashant Andoriya <[email protected]>
Date:   Mon Jun 10 20:52:48 2024 +0530

    Merge pull request andoriyaprashant#195 from RishavKumarSinha/fix#193

    Implemented FAQs Page in the Menu.

commit 902b3b1
Author: Rishav Kumar Sinha <[email protected]>
Date:   Mon Jun 10 12:21:44 2024 +0530

    Implemented FAQs Page in the Menu

commit 5a5845a
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:58:42 2024 +0530

    Delete lib/.gitignore

commit bf16de9
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:58:28 2024 +0530

    Delete lib/build.gradle

commit a7ae813
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:58:01 2024 +0530

    Delete lib/src/main/java/com/example/lib directory

commit 8047328
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:57:26 2024 +0530

    Delete gradlew.bat

commit 93035d8
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:57:11 2024 +0530

    Delete gradlew

commit 1c2ffe2
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 11:56:14 2024 +0530

    Delete gradle/wrapper directory

commit d597038
Author: Shubham-Zone <[email protected]>
Date:   Mon Jun 10 01:25:03 2024 +0530

    scrolling issue resolved

commit d12b89c
Merge: 3e469ea aafdf1c
Author: Prashant Andoriya <[email protected]>
Date:   Sun Jun 9 20:43:07 2024 +0530

    Merge pull request andoriyaprashant#191 from RishavKumarSinha/fix#173

    Implemented Page for Social Winter of Code

commit aafdf1c
Author: Rishav Kumar Sinha <[email protected]>
Date:   Sat Jun 8 17:17:34 2024 +0530

    Implemented Page for Social Winter of Code
@Shubham-Zone
Copy link
Contributor Author

@RishavKumarSinha this is the issue of responsiveness of the app ... you can add an issue related to the responsiveness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gssoc level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shubham-Zone @andoriyaprashant @RishavKumarSinha