Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciate flask #303

Closed
wants to merge 1 commit into from
Closed

Conversation

bilal-aamer
Copy link
Contributor

@bilal-aamer bilal-aamer commented Sep 27, 2023

Depreciates the flask dependency to a more recent stable version.
i.e. 2.3.2 -> 2.2.5

The following notebook can be a beginner friendly notebook: Beginner Notebook

Closes #152

@bilal-aamer
Copy link
Contributor Author

@VictorOdede @cartazio

Kindly review.

@cartazio
Copy link
Contributor

Why did you down grade the version … this seems incorrect

@bilal-aamer
Copy link
Contributor Author

There was an issue when importing the latest version of flask and 2.2.5 was the version that didn't through any issue when importing it on a Google Collab when running

!pip install llm-vm

After this one can essentially use the llm_vm module as usual.

I have attached a colab notebook for reference.

@VictorOdede
Copy link
Contributor

Is there a way to do this without downgrading Flask?

@bilal-aamer
Copy link
Contributor Author

bilal-aamer commented Oct 2, 2023

@VictorOdede, as per the discussions in the #152, flask was the module that was causing the issue, kept its version towards the latest that's compatible. So, not yet

@cartazio
Copy link
Contributor

cartazio commented Oct 2, 2023 via email

@cartazio
Copy link
Contributor

cartazio commented Oct 2, 2023

wontfix

@cartazio cartazio closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make llm-vm such that we can install on google colab
3 participants