Remove destructor assertion as it may not be comprehensive

anand1976 · May 30, 2024 · 3319afb · 3319afb
1 parent 326c0ea
commit 3319afb
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/table/block_fetcher.cc b/table/block_fetcher.cc
@@ -29,15 +29,6 @@
 
 namespace ROCKSDB_NAMESPACE {
 
-BlockFetcher::~BlockFetcher() {
-  // If we successfully read the block into fs_buf_, and its
-  // compressed, and we haven't returned the compressed block to the caller,
-  // ensure that we keep fs_buf_ till destruction in case GetCompressedBlock()
-  // is called.
-  assert(!io_status_.ok() || compression_type_ == kNoCompression ||
-         !do_uncompress_ || !use_fs_scratch_ || fs_buf_);
-}
-
 inline void BlockFetcher::ProcessTrailerIfPresent() {
   if (footer_.GetBlockTrailerSize() > 0) {
     assert(footer_.GetBlockTrailerSize() == BlockBasedTable::kBlockTrailerSize);

diff --git a/table/block_fetcher.h b/table/block_fetcher.h
@@ -78,8 +78,6 @@ class BlockFetcher {
     }
   }
 
-  ~BlockFetcher();
-
   IOStatus ReadBlockContents();
   IOStatus ReadAsyncBlockContents();
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,8 +78,6 @@ class BlockFetcher { @@
         }
       }
-      ~BlockFetcher();
       IOStatus ReadBlockContents();
       IOStatus ReadAsyncBlockContents();
@@ Expand Down @@