Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include files #129

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Include files #129

merged 7 commits into from
Dec 2, 2024

Conversation

IstvanZsSzekely
Copy link
Contributor

Added include files for both Make and system_project.tcl to allow easier include of groups that have many dependencies, such as DMA, JESD. Files that are not used in the design are ignored and not compiled, which means that this won't affect build and simulation times.
Updated all testbenches.

@IstvanZsSzekely IstvanZsSzekely added the update Update current feature label Nov 7, 2024
@IstvanZsSzekely IstvanZsSzekely self-assigned this Nov 7, 2024
@IstvanZsSzekely IstvanZsSzekely force-pushed the include_files branch 2 times, most recently from 05ac023 to b8575ce Compare November 19, 2024 06:07
@IstvanZsSzekely IstvanZsSzekely mentioned this pull request Nov 20, 2024
scripts/make_tb_path Outdated Show resolved Hide resolved
library/includes/Makeinclude_spi_engine Outdated Show resolved Hide resolved
- Added include files for major drivers
- Updated scripts

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond prefixing with .mk just to hint the code editors of the file type, I'm okay with the changes.

library/includes/Makeinclude_spi_engine Outdated Show resolved Hide resolved
scripts/make_tb_path Outdated Show resolved Hide resolved
@IstvanZsSzekely
Copy link
Contributor Author

Shall I add a .mk extension to make_tb_path all of the Makeinclude files so we know they are related to Make and it's easier for code editors to recognize it too?

@IstvanZsSzekely
Copy link
Contributor Author

Rebased on main and updated affected items.

- Separated Testbenches from HDL dependency

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@IstvanZsSzekely
Copy link
Contributor Author

Added the .mk suffix to the Make related files

@IstvanZsSzekely IstvanZsSzekely merged commit 86dff14 into main Dec 2, 2024
2 checks passed
@IstvanZsSzekely IstvanZsSzekely deleted the include_files branch December 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Update current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants