Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PeriphDrivers): Allow Skipping Clock and GPIO Initialization on Additional Peripherals #809

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat(PeriphDrivers): Allow Skipping Clock and GPIO Initialization on Additional Peripherals #809

merged 1 commit into from
Nov 30, 2023

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Nov 27, 2023 •
edited
Loading

Pull Request Template

Description

Propagate changes in this #730 to other peripherals.
The purpose of this change is to provide a way to the use pass clock & gpio initialization. Changes applied to below peripherals.

  • ADC
  • OWM
  • UART
  • AES/CRC/TRNG
  • HTMR
  • WUT
  • SPIXF/ SPIMSS

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) MAX32662 Related to the MAX32662 (ME12) labels Nov 27, 2023
@ozersa ozersa changed the title Add MSDK_NO_GPIO_CLK_INIT to disable clock&gpio init feat(PeriphDrivers): Propagate MSDK_NO_GPIO_CLK_INIT macro to other peripherals too Nov 27, 2023
@ozersa ozersa force-pushed the feat/disable_clock branch from 7dadf02 to 679ccf0 Compare November 27, 2023 10:11
@ozersa ozersa force-pushed the feat/disable_clock branch from 679ccf0 to 424351a Compare November 27, 2023 10:44
@Jake-Carter Jake-Carter changed the title feat(PeriphDrivers): Propagate MSDK_NO_GPIO_CLK_INIT macro to other peripherals too feat(PeriphDrivers): Allow Skipping Clock and GPIO Initialization on Additional Peripherals Nov 30, 2023
ozersa
ozersa commented Nov 30, 2023
View reviewed changes
Libraries/PeriphDrivers/Source/OWM/owm_me18.c Outdated
Comment on lines 73 to 75
// Set system level configurations
mxc_gpio_regs_t *gpio = gpio_cfg_owm.port;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines not needed.

ozersa
ozersa commented Nov 30, 2023
View reviewed changes
Libraries/PeriphDrivers/Source/OWM/owm_me17.c Outdated
Comment on lines 73 to 75
// Set system level configurations
mxc_gpio_regs_t *gpio = gpio_cfg_owm.port;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines not needed.

@ozersa
Add MSDK_NO_GPIO_CLK_INIT to disable clock&gpio init
ef00334 
Added for below peripherals
- ADC
- OWM
- UART
- AES/CRC/TRNG
- HTMR
- WUT
- SPIXF/ SPIMSS

Signed-off-by: Sadik Ozer <[email protected]>
@ozersa ozersa force-pushed the feat/disable_clock branch from 81dea56 to ef00334 Compare November 30, 2023 06:21
@ozersa
Copy link
Contributor Author

ozersa commented Nov 30, 2023

Rebased onto origin/main to remove addition lines comes.

@Jake-Carter Jake-Carter merged commit 7fe9ab5 into main Nov 30, 2023
8 checks passed
@Jake-Carter Jake-Carter deleted the feat/disable_clock branch November 30, 2023 21:08
@ozersa ozersa mentioned this pull request Feb 26, 2024
Merged
4 tasks
@karaanil karaanil mentioned this pull request Mar 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacob-Scheiffler Jacob-Scheiffler Jacob-Scheiffler approved these changes

@Jake-Carter Jake-Carter Jake-Carter approved these changes

@sihyung-maxim sihyung-maxim Awaiting requested review from sihyung-maxim

@lorne-maxim lorne-maxim Awaiting requested review from lorne-maxim

Assignees
No one assigned
Labels
MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32662 Related to the MAX32662 (ME12) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozersa @Jake-Carter @Jacob-Scheiffler