fix(Examples): Fixed bug in FaceId RISC-V example #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
suggested changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks @vicloginov
One minor comment below - can we use TFT_ENABLE or ENABLE_TFT across both examples? I think it will help if we make this definition consistent
| @@ -23,7 +23,7 @@ endif | |||
| # Place build files specific to FTHR_RevA here. | |||
| ifeq "$(BOARD)" "FTHR_RevA" | |||
| # Only Enable if 2.4" TFT is connected to Feather | |||
| #PROJ_CFLAGS+=-DENABLE_TFT | |||
| #PROJ_CFLAGS+=-DTFT_ENABLE | |||
There was a problem hiding this comment.
Mismatch between TFT_ENABLE here
| @@ -19,7 +20,7 @@ endif | |||
| # Place build files specific to FTHR_RevA here. | |||
| ifeq "$(BOARD)" "FTHR_RevA" | |||
| # Only Enable if 2.4" TFT is connected to Feather | |||
| # PROJ_CFLAGS+=-DENABLE_TFT | |||
| #PROJ_CFLAGS+=-DENABLE_TFT | |||
There was a problem hiding this comment.
Agree. I will rename it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug of FaceId RISC-V example when it's executed on MAX78000 Feather board.