Enable Osc Plot #513
Open
Enable Osc Plot #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dNechita
reviewed
Jan 10, 2025
osc.c
Outdated
| @@ -167,7 +167,7 @@ unsigned global_enabled_channels_mask(struct iio_device *dev, struct iio_channel | |||
| unsigned mask = 0; | |||
| int scan_i = 0; | |||
| unsigned int i = 0; | |||
| //struct iio_channels_mask *ch_mask = iio_get_channels_mask(iio_device_get_channels_count(dev)); | |||
| //struct iio_channels_mask *ch_mask = iio_create_channels_mask(iio_device_get_channels_count(dev)); | |||
There was a problem hiding this comment.
You forgot to uncomment the variable that stores the channels mask.
There was a problem hiding this comment.
Still not addressed. Was it on purpose?
nunojsa
reviewed
Feb 4, 2025
There was a problem hiding this comment.
@dNechita, @cristina-suteu, Can we move this forward? I think it's time for us (ADI) to really start using and pushing libiio v1. Having osc core done would be a very good start so that we could start updating individual plugins.
| * that's because someone else broke the lock | ||
| */ | ||
| if (markers_copy) { | ||
| osc_plot_set_markers_copy(plot, NULL); |
There was a problem hiding this comment.
i'll fix the indentation in a final commit , after changes have been reviewed
nunojsa
reviewed
Feb 5, 2025
osc.c
Outdated
| @@ -167,7 +167,7 @@ unsigned global_enabled_channels_mask(struct iio_device *dev, struct iio_channel | |||
| unsigned mask = 0; | |||
| int scan_i = 0; | |||
| unsigned int i = 0; | |||
| //struct iio_channels_mask *ch_mask = iio_get_channels_mask(iio_device_get_channels_count(dev)); | |||
| //struct iio_channels_mask *ch_mask = iio_create_channels_mask(iio_device_get_channels_count(dev)); | |||
There was a problem hiding this comment.
Still not addressed. Was it on purpose?
osc.c
Outdated
| else { | ||
| attribute = iio_device_find_attr(dev, attr); | ||
| ret = iio_attr_write_longlong(attribute, lval); | ||
| } |
osc.c
Outdated
| } else if (debug) { | ||
| attribute = iio_device_find_debug_attr(dev, attr); | ||
| ret = iio_attr_write_longlong(attribute, lval); | ||
| } |
osc.c
Outdated
| ret = iio_attr_write(attribute, value); | ||
| } else { | ||
| attribute = iio_device_find_attr(dev, attr); | ||
| ret = iio_attr_write(attribute,value); | ||
| } |
There was a problem hiding this comment.
also odd in here though it seems it was wrong before
dNechita
reviewed
Feb 5, 2025
oscmain.c
Outdated
| @@ -255,7 +255,7 @@ gint main (int argc, char **argv) | |||
| if (!ctx) | |||
| connect_dialog(false); | |||
| // !!!!!!! | |||
There was a problem hiding this comment.
Is creating a default plot still problematic? If not, you should remove the comment with the exclamation marks.
dNechita
reviewed
Feb 5, 2025
| @@ -2148,7 +2155,8 @@ static gboolean check_valid_setup_of_device(OscPlot *plot, const char *name) | |||
| gtk_widget_set_tooltip_text(priv->capture_button, | |||
| "Time Domain needs at least one channel"); | |||
| return false; | |||
| } else if (dev && !dma_valid_selection(name, enabled_channels_mask | global_enabled_channels_mask(dev), nb_channels)) { | |||
| } else if (dev && !dma_valid_selection(name, enabled_channels_mask | | |||
There was a problem hiding this comment.
It's no longer necessary to check 'dev' since you added a check already which will exist this function.
Signed-off-by: Cristina Suteu <[email protected]>
use libiio1 stream object use libiio1 API re-enable plotting functions TO DO: context clone and osc_test_value functions Signed-off-by: Cristina Suteu <[email protected]>
Signed-off-by: Cristina Suteu <[email protected]>
cristina-suteu
force-pushed
the
libiio1-plot
branch
from
3954063 to
f2e7c76
Compare
read attributes correctly when loading plugins update osc_test_value function for both device and channel attrs update osc_read_nonenclosed_value to do the same remove context clone remove unnecessary commented lines fix indent issues Signed-off-by: Cristina Suteu <[email protected]>
in osc.c, each struct iio_device and iio_channel get assigned some dynamically allocated memory which never gets freed. Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Cristina Suteu <[email protected]>
cristina-suteu
force-pushed
the
libiio1-plot
branch
from
9adad68 to
1674487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Osc plot now uses libiio v1 API and data is captured with the iio_stream object.
PR Type
PR Checklist