Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Stripo email editor to tools #2439

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Conversation

antongrinenko
Copy link
Contributor

@antongrinenko antongrinenko commented Jul 8, 2019

Fixes #2438.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@antongrinenko
Copy link
Contributor Author

I signed it!

@matthiasrohmer
Copy link
Collaborator

@fstanis requested you for review according to ampproject/wg-outreach#15 as you're part of the wg-amp4email.

@fstanis
Copy link
Collaborator

fstanis commented Jul 9, 2019

Approved, but the CLA seems to still be pending. You may have used a different address in your commit, to fix that:

  1. Go to https://cla.developers.google.com/clas and check which email you used
  2. Make sure this is the one git uses: git config --global user.email [email protected]
  3. Rewrite the email in your last commit: git commit --amend --reset-author --no-edit
  4. Force push: git push origin future -f

@antongrinenko
Copy link
Contributor Author

Approved, but the CLA seems to still be pending. You may have used a different address in your commit, to fix that:

  1. Go to https://cla.developers.google.com/clas and check which email you used
  2. Make sure this is the one git uses: git config --global user.email [email protected]
  3. Rewrite the email in your last commit: git commit --amend --reset-author --no-edit
  4. Force push: git push origin future -f

Done

@DKulaksyz
Copy link

Hello @matthiasrohmer , can we ask you to review the cla/google check again? Thanks

@fstanis
Copy link
Collaborator

fstanis commented Jul 12, 2019

The CLA is reviewed automatically, neither Matthias nor I can do much here.

Go to https://cla.developers.google.com/clas and make sure it's signed with the correct username (@antongrinenko needs to do it, as the author of the PR) and with the same email used in the commits (the one you set with git config --global user.email [email protected]). If this email is not listed, add it in https://github.com/settings/profile

@DKulaksyz
Copy link

DKulaksyz commented Jul 12, 2019

Thank you, Filip. Will check with Anton again.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@DKulaksyz
Copy link

DKulaksyz commented Jul 12, 2019

@fstanis seems like we did it :) Thanks a lot for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Stripo email editor" to the AMP Tools Listing
5 participants