Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bootstrap initial local evaluation flags #93

Merged
merged 8 commits into from
Feb 6, 2024
Merged

feat: bootstrap initial local evaluation flags #93

merged 8 commits into from
Feb 6, 2024

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Nov 30, 2023

Summary

bootstrap initial local evaluation flags

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tyiuhc tyiuhc requested a review from bgiori November 30, 2023 23:47
bgiori
bgiori approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, couple of little changes before merging

packages/experiment-browser/src/config.ts Outdated Show resolved Hide resolved
packages/experiment-browser/src/config.ts Outdated Show resolved Hide resolved
packages/experiment-browser/src/experimentClient.ts Outdated Show resolved Hide resolved
packages/experiment-browser/src/experimentClient.ts Outdated Show resolved Hide resolved
@tyiuhc tyiuhc marked this pull request as draft January 30, 2024 22:22
@tyiuhc tyiuhc marked this pull request as ready for review January 30, 2024 22:22
@tyiuhc tyiuhc merged commit 53a9ded into main Feb 6, 2024
6 checks passed
@tyiuhc tyiuhc deleted the initial-flags branch February 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyiuhc @bgiori