Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load text domain later #21

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Load text domain later #21

wants to merge 1 commit into from

Conversation

jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Mar 4, 2025

Fixes #19

steps to test:

  • before checkout
  • be on wp 6.7
  • make sure the plugin is active
  • install and activate query monitor
  • view the site
  • see the deprecation notice from WP Core
  • checkout this pr
  • reload the site
  • the deprecation notice should disappear
  • the plugin should still function correctly
  • the aip text domain should still load correctly (check via query monitor on non-EN)

@jaymcp jaymcp assigned Gentyspun and unassigned Gentyspun Mar 4, 2025
@jaymcp jaymcp requested a review from Gentyspun March 4, 2025 15:37
Copy link

@Gentyspun Gentyspun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text domain loaded too early
2 participants