Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate script localisation from theme #20

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Mar 4, 2025

Ref amnestywebsite/humanity-theme#285

As part of the Block API migration work taking place in the theme, the theme's script localisation work has been re-done. During that process, it was found that there were some values being localised against theme scripts that were actually external to the theme. These are therefore being migrated to their appropriate place.

Steps to test:

  1. on the theme, switch to PR#551
  2. run a build
  3. ensure you have WooCommerce Checkout Manager enabled
  4. go to wp-admin -> woocommerce -> settings -> checkout -> additional
  5. add a new field if there isn't one already existing
  6. the field should be a select, and should have more than one option
  7. note the field id (e.g. additional_wooccm0)
  8. edit a post/page
  9. insert a donation block
  10. in the sidebar, there should be a panel labelled "Campaigns"
  11. the panel should contain a dropdown labelled "Campaign options field"
  12. the dropdown should contain the field you added in step 4
  13. when selecting that field from the dropdown, the block should render a dropdown containing the options you added to the field in step 4

@jaymcp jaymcp requested a review from Gentyspun March 4, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant