workflow: remove previously_rejected to accept updates

Signed-off-by: Antonio Cesarano <[email protected]> Removes the check that rejects records if already harvested more than 5 days ago.
ammirate · Sep 28, 2017 · 924efd1 · 924efd1
1 parent 20b4bf6
commit 924efd1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 31 deletions.
diff --git a/inspirehep/modules/workflows/tasks/matching.py b/inspirehep/modules/workflows/tasks/matching.py
@@ -247,25 +247,6 @@ def already_harvested(obj, eng):
     return False
 
 
-def previously_rejected(days_ago=None):
-    """Check if record exist on INSPIRE or already rejected."""
-    @with_debug_logging
-    @wraps(previously_rejected)
-    def _previously_rejected(obj, eng):
-        if days_ago is None:
-            _days_ago = current_app.config.get('INSPIRE_ACCEPTANCE_TIMEOUT', 5)
-        else:
-            _days_ago = days_ago
-
-        if is_too_old(obj.data, days_ago=_days_ago):
-            obj.log.info("Record is likely rejected previously.")
-            return True
-
-        return False
-
-    return _previously_rejected
-
-
 @with_debug_logging
 def pending_in_holding_pen(obj, eng):
     """Check if a record exists in HP by looking in given KB."""

diff --git a/inspirehep/modules/workflows/workflows/article.py b/inspirehep/modules/workflows/workflows/article.py
@@ -72,7 +72,6 @@
     pending_in_holding_pen,
     article_exists,
     already_harvested,
-    previously_rejected,
     update_existing_workflow_object,
 )
 from inspirehep.modules.workflows.tasks.upload import store_record, set_schema
@@ -138,17 +137,6 @@
                     mark('stop', True),
                 ]
             ),
-            # FIXME: This filtering step should be removed when:
-            #        old previously rejected records are treated
-            #        differently e.g. good auto-reject heuristics or better
-            #        time based filtering (5 days is quite random now).
-            IF(
-                previously_rejected(),
-                [
-                    mark('already-ingested', True),
-                    mark('stop', True),
-                ]
-            ),
         ]
     ),
 ]