[Feature] Add support for configuring labels emitted in metrics #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In environments with lots of nodes or lots of certificates (or both), emitting all labels might prove problematic due to the increased cardinality. To keep cardinality under control, this commit introduces a way to configure which labels should be emitted, by introducing a new command line switch, `--include-labels`. Examples: ``` $ ./bin/node-cert-exporter ... --include-labels alg,path,subject $ ./bin/node-cert-exporter ... --include-labels alg --include-labels path ``` Signed-off-by: Costas Drogos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments with lots of nodes or lots of certificates (or both), emitting all labels might prove problematic due to the increased cardinality.
To keep cardinality under control, this commit introduces a way to configure which labels should be emitted, by introducing a new command line switch,
--include-labels.Examples:
- What I did
Introduced a new switch that allows for choosing which labels emitted metrics should have.
- How I did it
New switch, conditionals in exporter.go
- How to verify it
--include-labelsswitch, which should show the presence of absence of labels.- Description for the CHANGELOG
Configurable labels in metrics are now possible