Feature: Read replica support #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job so far :) Let's keep the progress going! |
Granite::Connections now accept connections with writer/reader. See spec/spec_helper spec/adapters_spec Added env var to store url to sqlite replica db url
…ack. Simplified callbacks
automatically switch to the writer adapter before saving to database.
a-alhusaini
changed the title
…er if available instead of using first connection in Granite::Connections
update specs
spec updates
robacarp
reviewed
May 11, 2023
robacarp
reviewed
May 11, 2023
crimson-knight
requested changes
May 15, 2023
… there was no switch to reader adapter. Added test for connection switching
…iod. Fixed invalid test.
…nections to allow changing it globally
…cate connection pool
crimson-knight
approved these changes
Jun 12, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in handling #475. The next step is to create a mechanism that lets the adapter know about the reader/writer if they exist and decide which one to run based on the information provided to it.
I however, deem this a good milestone for a PR. This change is large and handling merge conflicts would be a pain. Better to PR it in step by step.