1221 configurable static response headers #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abilty to configure response headers from <environment>.cr file
with the following configuration,
public_file_server:
headers:
"Cache-Control": "private, max-age=7200"
Update env/dev and env/production with public file server default configurations
drujensen
previously approved these changes
Sep 30, 2020
Modify configuration such that each pipe can be independantly configured via settings
drujensen
approved these changes
Oct 3, 2020
eliasjpr
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to configure response headers from .yml file
with the following configuration,
Description of the Change
When files are served by the static file server, via pipes/static.cr, and does not expose a way to modify the hard coded Cache-Control headers
Alternate Designs
This enhancement is similar to the static file middle-ware headers configuration of Rails. Original PR
Benefits
Ability to modify response headers for files served by static pipe.
Possible Drawbacks
Since this PR is an enhancement to the existing functionality, no changes are introduced to the behavior of the framework.