Skip to content

Overhaul the text parsers, port from nom to winnow (#892) #3568

Overhaul the text parsers, port from nom to winnow (#892)

Overhaul the text parsers, port from nom to winnow (#892) #3568

GitHub Actions / clippy failed Jan 9, 2025 in 1s

clippy

5 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 5
Warning 0
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check failure on line 670 in src/lazy/expanded/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

error: this `match` expression can be replaced with `?`
   --> src/lazy/expanded/mod.rs:667:38
    |
667 |                       let next_value = match evaluator.next() {
    |  ______________________________________^
668 | |                         Ok(value) => value,
669 | |                         Err(e) => return Err(e),
670 | |                     };
    | |_____________________^ help: try instead: `evaluator.next()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Check failure on line 645 in src/lazy/expanded/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

error: this `match` expression can be replaced with `?`
   --> src/lazy/expanded/mod.rs:642:42
    |
642 |                       let resolved_e_exp = match e_exp.resolve(context_ref) {
    |  __________________________________________^
643 | |                         Ok(resolved) => resolved,
644 | |                         Err(e) => return Err(e),
645 | |                     };
    | |_____________________^ help: try instead: `e_exp.resolve(context_ref)?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Check failure on line 564 in src/lazy/expanded/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

error: this `match` expression can be replaced with `?`
   --> src/lazy/expanded/mod.rs:561:38
    |
561 |                   let resolved_e_exp = match e_exp.resolve(context_ref) {
    |  ______________________________________^
562 | |                     Ok(resolved) => resolved,
563 | |                     Err(e) => return Err(e),
564 | |                 };
    | |_________________^ help: try instead: `e_exp.resolve(context_ref)?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Check failure on line 995 in src/lazy/expanded/macro_evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

error: this `match` expression can be replaced with `?`
   --> src/lazy/expanded/macro_evaluator.rs:992:24
    |
992 |               let step = match current_expansion.next_step() {
    |  ________________________^
993 | |                 Ok(step) => step,
994 | |                 Err(e) => return Err(e),
995 | |             };
    | |_____________^ help: try instead: `current_expansion.next_step()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Check failure on line 949 in src/lazy/expanded/macro_evaluator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` expression can be replaced with `?`

error: this `match` expression can be replaced with `?`
   --> src/lazy/expanded/macro_evaluator.rs:946:25
    |
946 |           let expansion = match macro_expr.expand() {
    |  _________________________^
947 | |             Ok(expansion) => expansion,
948 | |             Err(e) => return Err(e),
949 | |         };
    | |_________^ help: try instead: `macro_expr.expand()?`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `-D clippy::question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`