The enter key will be enabled depending on the value of `InputContext… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaRicchi
requested changes
Apr 4, 2024
src/qml/EnterKey.qml
Outdated
| @@ -9,6 +9,6 @@ Key { | |||
| btnText: "\n" | |||
| btnDisplayedText: InputPanel.enterIcon === "" ? "Enter" : "" | |||
| btnIcon: InputPanel.enterIcon === "" ? "" : InputPanel.enterIcon | |||
| enabled: InputContext.inputItem?.EnterKeyAction.enabled ?? true | |||
| enabled: (InputContext.inputItem)?InputContext.inputItem.EnterKeyAction.enabled : true | |||
There was a problem hiding this comment.
Format the code:
Suggested change
| enabled: (InputContext.inputItem)?InputContext.inputItem.EnterKeyAction.enabled : true | |
| enabled: (InputContext.inputItem) ? InputContext.inputItem.EnterKeyAction.enabled : true |
AndreaRicchi
requested changes
Apr 5, 2024
src/qml/EnterKey.qml
Outdated
| @@ -9,6 +9,6 @@ Key { | |||
| btnText: "\n" | |||
| btnDisplayedText: InputPanel.enterIcon === "" ? "Enter" : "" | |||
| btnIcon: InputPanel.enterIcon === "" ? "" : InputPanel.enterIcon | |||
| enabled: InputContext.inputItem?.EnterKeyAction.enabled ?? true | |||
| enabled: InputContext.inputItem ? InputContext.inputItem.EnterKeyAction.enabled : true | |||
There was a problem hiding this comment.
Remove the empty space at the end
|
|
EddyTheCo
force-pushed
the
fix_runtime_error_from_qml_typo
branch
from
d659506 to
321702f
Compare
|
I have squashed all the commits of my branch. Perhaps a squash and merge from your side would be a better workflow. |
The enter key will be enabled depending on the value of `InputContext.inputItem.EnterKeyAction.enabled`.
EddyTheCo
force-pushed
the
fix_runtime_error_from_qml_typo
branch
from
321702f to
970d070
Compare
|
Having three commits for a single line change is bad in any scenario. Specifically formatting code that you changed must be amended in your first commit instead of having:
It's a bad practice and should be squashed by the submitter |
AndreaRicchi
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enter key will be enabled depending on the value of
InputContext.inputItem.EnterKeyAction.enabled.This should fix #10