chore: remove is prefix from constructors (#202)

altmp · Apr 7, 2024 · 4252afd · 4252afd
1 parent 65fe62d
commit 4252afd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/client/js/compatibility/classes/webview.js b/client/js/compatibility/classes/webview.js
@@ -18,8 +18,8 @@ class WebView extends alt.WebView {
 
         let instance = null;
         if (args.length == 4) {
-            const [_, isOverlay, pos, size] = args;
-            instance = alt.WebView.create({ url, isOverlay, pos, size });
+            const [_, overlay, pos, size] = args;
+            instance = alt.WebView.create({ url, overlay, pos, size });
         } else if (args.length == 3 && isObject(args[2])) {
             const [_, pos, size] = args;
             instance = alt.WebView.create({ url, pos, size });
@@ -30,8 +30,8 @@ class WebView extends alt.WebView {
             const [_, pos] = args;
             alt.WebView.create({ url, pos });
         } else if (args.length == 2) {
-            const isOverlay = args[1];
-            instance = alt.WebView.create({ url, isOverlay });
+            const overlay = args[1];
+            instance = alt.WebView.create({ url, overlay });
         } else {
             instance = alt.WebView.create({ url });
         }

diff --git a/client/src/factories/AudioFactory.cpp b/client/src/factories/AudioFactory.cpp
@@ -9,7 +9,7 @@ static js::FactoryHandler audioFactory(alt::IBaseObject::Type::AUDIO, [](js::Obj
     float volume;
     if(!args.Get("volume", volume)) return nullptr;
 
-    bool isRadio = args.Get<bool>("isRadio", false);
+    bool isRadio = args.Get<bool>("radio", false);
     bool clearCache = args.Get<bool>("clearCache", true);
 
     js::IResource* resource = args.GetResource();

diff --git a/client/src/factories/WebViewFactory.cpp b/client/src/factories/WebViewFactory.cpp
@@ -20,8 +20,8 @@ static js::FactoryHandler webViewFactory(alt::IBaseObject::Type::WEBVIEW, [](js:
     {
         alt::Vector2i pos = args.Get<alt::Vector2i>("pos", {0, 0});
         alt::Vector2i size = args.Get<alt::Vector2i>("size", {0, 0});
-        bool isVisible = args.Get("isVisible", true);
-        bool isOverlay = args.Get("isOverlay", false);
+        bool isVisible = args.Get("visible", true);
+        bool isOverlay = args.Get("overlay", false);
 
         return alt::ICore::Instance().CreateWebView(url, pos, size, isVisible, isOverlay, args.GetResource()->GetResource());
     }

diff --git a/types/client/index.d.ts b/types/client/index.d.ts
@@ -65,7 +65,7 @@ declare module "@altv/client" {
     export interface AudioCreateOptions {
         source: string;
         volume: number;
-        isRadio?: boolean; // default: false
+        radio?: boolean; // default: false
         clearCache?: boolean; // default: true
     }
 
@@ -1234,8 +1234,8 @@ declare module "@altv/client" {
         url: string;
         pos?: altShared.IVector2; // default: { x: 0, y: 0 }
         size?: altShared.IVector2; // default: { x: 0, y: 0 }
-        isVisible?: boolean; // default: true
-        isOverlay?: boolean; // default: false
+        visible?: boolean; // default: true
+        overlay?: boolean; // default: false
     }
 
     export abstract class WebView extends BaseObject {