-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support flatpak #2746
support flatpak #2746
Conversation
Reviewer's Guide by SourceryThis pull request adds support for building and distributing Altair GraphQL Client as a Flatpak. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR description template properly, including which issue this PR addresses and a description of the changes being introduced.
- The Electron version bump from 26.2.2 to 33.2.1 is significant. Please document any breaking changes or migration considerations that need to be taken into account.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
runtimeVersion: '24.08' | ||
baseVersion: '24.08' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: The specified Flatpak runtime version '24.08' is a future version that hasn't been released yet.
Consider using the current stable runtime version (like '23.08') to ensure immediate build compatibility.
Visit the preview URL for this PR (updated for commit 17f9462): https://altair-gql--pr2746-imolorhe-flatpak-sup-6ru2tk6k.web.app (expires Tue, 07 Jan 2025 18:46:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
In future, we can deploy the flatpak to one of the available repositories using this github action. |
Fixes
Partially resolves #649
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
Upgrade Electron to version 33.2.1 and add support for Flatpak builds.
Build:
CI: