Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatool: Enable Exporting of ELF #638

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Datatool: Enable Exporting of ELF #638

merged 2 commits into from
Jan 30, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Jan 29, 2025

Description

  • Enables datatool to generate and export elf to the specified dir

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 55.94%. Comparing base (6ced1e8) to head (632dcaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
provers/sp1/src/lib.rs 0.00% 38 Missing ⚠️
bin/datatool/src/util.rs 0.00% 11 Missing ⚠️
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   56.04%   55.94%   -0.10%     
==========================================
  Files         297      298       +1     
  Lines       32804    32853      +49     
==========================================
- Hits        18384    18379       -5     
- Misses      14420    14474      +54     
Files with missing lines Coverage Δ
bin/datatool/src/args.rs 0.00% <ø> (ø)
bin/datatool/src/util.rs 0.00% <0.00%> (ø)
provers/sp1/src/lib.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Commit: d232a7f

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 101,655
CL_BLOCK 57,537
L1_BATCH 30,387,722
L2_BATCH 5,473
CHECKPOINT 15,255

@MdTeach MdTeach force-pushed the STR-959-export-elf branch from d4188ec to d8f1f19 Compare January 30, 2025 03:44
@MdTeach MdTeach force-pushed the STR-959-export-elf branch from d8f1f19 to b63f088 Compare January 30, 2025 04:33
@MdTeach MdTeach marked this pull request as ready for review January 30, 2025 06:35
@MdTeach MdTeach requested review from a team as code owners January 30, 2025 06:35
provers/sp1/src/lib.rs Outdated Show resolved Hide resolved
@MdTeach MdTeach force-pushed the STR-959-export-elf branch from b63f088 to c5f2bec Compare January 30, 2025 09:10
@MdTeach MdTeach force-pushed the STR-959-export-elf branch from c5f2bec to 632dcaf Compare January 30, 2025 09:11
@MdTeach MdTeach requested a review from prajwolrg January 30, 2025 09:56
@prajwolrg prajwolrg added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 072b663 Jan 30, 2025
17 of 19 checks passed
@prajwolrg prajwolrg deleted the STR-959-export-elf branch January 30, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants