Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-889: Make prover CI workflow run only on pull requests #629

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

evgenyzdanovich
Copy link
Contributor

Description

Make prover CI workflow run only on pull requests (thus disabling the run on merge).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.35%. Comparing base (78aa39f) to head (d8dbfe0).
Report is 21 commits behind head on main.

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   56.37%   56.35%   -0.03%     
==========================================
  Files         316      316              
  Lines       32754    32754              
==========================================
- Hits        18466    18458       -8     
- Misses      14288    14296       +8     

see 4 files with indirect coverage changes

Copy link
Contributor

Commit: be68b74

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,421
EL_BLOCK 98,789
CL_BLOCK 57,378
L1_BATCH 30,387,324
L2_BATCH 5,473
CHECKPOINT 15,895

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8dbfe0

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit c6ef01c Feb 3, 2025
20 checks passed
@evgenyzdanovich evgenyzdanovich deleted the str-889 branch February 3, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants