-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-907 Generation of consistant verification key using datatool binary #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 55.97% 55.89% -0.09%
==========================================
Files 315 315
Lines 33428 33428
==========================================
- Hits 18712 18683 -29
- Misses 14716 14745 +29 |
Commit: 2974527 SP1 Performance Test Results
|
storopoli
requested changes
Jan 23, 2025
d0ed68b
to
eb02d8f
Compare
daef0eb
to
808de08
Compare
storopoli
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 808de08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default the sp1 verification key is not consistent. For the consistant verification key we need to do guest build with docker.
Type of Change
Notes to Reviewers
Currently had to usesp1-helper = { git = "https://github.com/alpenlabs/sp1.git", branch = "feat/docker-optional-workspace-dev-v4" }
Created the PR on SP1 endChecklist
Related Issues