Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-907 Generation of consistant verification key using datatool binary #628

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Jan 22, 2025

Description

By default the sp1 verification key is not consistent. For the consistant verification key we need to do guest build with docker.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

  • Currently had to use sp1-helper = { git = "https://github.com/alpenlabs/sp1.git", branch = "feat/docker-optional-workspace-dev-v4" }
  • Created the PR on SP1 end

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach marked this pull request as ready for review January 22, 2025 18:23
@MdTeach MdTeach requested review from a team as code owners January 22, 2025 18:23
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (0db65b9) to head (808de08).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   55.97%   55.89%   -0.09%     
==========================================
  Files         315      315              
  Lines       33428    33428              
==========================================
- Hits        18712    18683      -29     
- Misses      14716    14745      +29     

see 7 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Commit: 2974527

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,421
EL_BLOCK 98,534
CL_BLOCK 57,370
L1_BATCH 30,387,324
L2_BATCH 5,473
CHECKPOINT 15,895

bin/datatool/README.md Show resolved Hide resolved
bin/datatool/README.md Show resolved Hide resolved
bin/datatool/README.md Outdated Show resolved Hide resolved
bin/datatool/README.md Outdated Show resolved Hide resolved
provers/sp1/Cargo.toml Outdated Show resolved Hide resolved
provers/sp1/build.rs Show resolved Hide resolved
@MdTeach MdTeach force-pushed the STR-907-docker-vkey branch from d0ed68b to eb02d8f Compare January 28, 2025 09:49
@MdTeach MdTeach force-pushed the STR-907-docker-vkey branch from daef0eb to 808de08 Compare January 28, 2025 11:06
@MdTeach MdTeach requested a review from storopoli January 28, 2025 11:08
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 808de08

@MdTeach MdTeach added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit bae4d8d Jan 28, 2025
19 checks passed
@MdTeach MdTeach deleted the STR-907-docker-vkey branch January 28, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants