-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-953: btcio
backport (and some new) strata-bridge RPCs
#616
Conversation
@Rajil1213 these are the only ones missing here apart from the superblocks that we're not backporting. |
btcio
backport strata-bridge RPCs
Commit: 87297c0 SP1 Performance Test Results
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 56.37% 56.50% +0.12%
==========================================
Files 316 316
Lines 32754 33106 +352
==========================================
+ Hits 18466 18705 +239
- Misses 14288 14401 +113
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But since we're at it, we might want to add a few more RPCs that are relevant to the bridge for the Testnet I impl:
submit_package
(for CPFP in core 28.0)gettxout
(to check if a particular utxo exists)
This is not too urgent at the moment though so feel free to create separate tickets for these if there are other tasks of higher priority that you might want to be doing instead.
@bibek thanks for the review. I also added the EDIT: this PR is really easy to review if you check the commits, they do follow a very a good logic and are atomic in a sense. |
btcio
backport strata-bridge RPCsbtcio
backport (and some new) strata-bridge RPCs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor query. And a very nice commit history indeed !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Requesting a few additional test cases though.
btcio
backport (and some new) strata-bridge RPCsbtcio
backport (and some new) strata-bridge RPCs
@bewakes and @delbonis just look at the last two commits. |
Description
Backports
strata-bridge::btcio
RPCs tostrata::btcio
.Needed to remove
strata-bridge
'sbtcio
and use thestrata::btcio
instead.get_current_timestamp
test_mempool_accept
get_tx_out
submit_package
Type of Change
Checklist
Related Issues
STR-953