Str-760: re-enable prover fn-tests

[evgenyzdanovich]

Description

Re-enable prover fn-tests.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactor
• New or updated tests
• Dependency Update

Notes to Reviewers

During the testing, it was discovered that ProverOp impls have a bug, so it required some refactoring in prover-client first.

The essense of the bug: when dependency task is present (for example, when running cl_stf on some params and then running cl_agg that includes cl_stf with the same params), the implementation throws an error because it tries to write to db an existing entry.

It's been decided to always check for dependencies tasks first, and reuse if any.

Checklist

• I have performed a self-review of my code.
• I have commented my code where necessary.
• I have updated the documentation if needed.
• My changes do not introduce new warnings.
• I have added tests that prove my changes are effective or that my feature works.
• New and existing tests pass with my changes.

Related Issues

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (c66d479) to head (54dad8d).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
bin/prover-client/src/operators/checkpoint.rs	0.00%	46 Missing ⚠️
bin/prover-client/src/operators/mod.rs	0.00%	28 Missing ⚠️
bin/prover-client/src/operators/cl_stf.rs	0.00%	22 Missing ⚠️
bin/prover-client/src/operators/cl_agg.rs	0.00%	19 Missing ⚠️
bin/prover-client/src/operators/evm_ee.rs	0.00%	5 Missing ⚠️
bin/prover-client/src/operators/l1_batch.rs	0.00%	5 Missing ⚠️
bin/prover-client/src/operators/btc.rs	0.00%	4 Missing ⚠️

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   56.50%   56.79%   +0.28%     
==========================================
  Files         308      308              
  Lines       32297    32378      +81     
==========================================
+ Hits        18251    18388     +137     
+ Misses      14046    13990      -56     

Files with missing lines	Coverage Δ
bin/prover-client/src/operators/btc.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/evm_ee.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/l1_batch.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/cl_agg.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/cl_stf.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/mod.rs	0.00% <0.00%> (ø)
bin/prover-client/src/operators/checkpoint.rs	0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

[github-actions]

Commit: c59807d

SP1 Performance Test Results

program	cycles	success
BTC_BLOCKSPACE	7,239,474	✅
EL_BLOCK	100,495	✅
CL_BLOCK	55,340	✅
L1_BATCH	12,460,065	✅
L2_BATCH	5,448	✅
CHECKPOINT	15,322	✅

[delbonis]

Good, this feels cleaner now even if it was largely reorganization.

[storopoli]

minor nit

[prajwolrg]

Great work on also cleaning up the trait. It was looking a bit clunky.

[storopoli]

ACK 54dad8d