Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang format integration #214

Merged
merged 3 commits into from
Sep 3, 2021
Merged

clang format integration #214

merged 3 commits into from
Sep 3, 2021

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Sep 1, 2021 •
edited
Loading

Add clang-format file and corresponding CI tests.

@psychocoderHPC psychocoderHPC added this to the 0.4.0 milestone Sep 1, 2021
@psychocoderHPC psychocoderHPC requested a review from a team September 1, 2021 09:13
@psychocoderHPC
add clang-format file
ff2fb5c 
Add alpaka's clang format file and add to `IncludeCategories:` a section
about cupla includes.
@psychocoderHPC
apply clang-format
d3a9ba7 
Format code.

```
find src example include test  -iname "*.def" \
  -o -iname "*.h" -o -iname "*.cpp" -o -iname "*.hpp" \
  | xargs clang-format-11 -i
```
@psychocoderHPC
CI: test code formation
3ac491d 
Test code formation with clang-format-11.
@psychocoderHPC psychocoderHPC marked this pull request as ready for review September 1, 2021 12:37
@psychocoderHPC psychocoderHPC force-pushed the topic-clangFormat branch 2 times, most recently from eb4069b to 3ac491d Compare September 3, 2021 07:50
sbastrakov
sbastrakov approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@sbastrakov sbastrakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, cupla documentation never mentions that code is clang-formatted (unlike alpaka and PIConGPU documentation). but I don't see a place to put it

@sbastrakov sbastrakov merged commit 594da19 into alpaka-group:dev Sep 3, 2021
@psychocoderHPC psychocoderHPC deleted the topic-clangFormat branch September 3, 2021 16:54
@SimeonEhrig SimeonEhrig mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbastrakov sbastrakov sbastrakov approved these changes

Assignees
No one assigned
Labels
testing/CI
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@psychocoderHPC @sbastrakov