Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ecom 2090 bug block is not reloaded when country is not eligible #309

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

Linear task

Code changes

Refactor Alma client service
add BlocksDataService
Add alma_store redux store
and more ....

How to test

Test all blocks and standard gateway with and without inpage
Good Luck !

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Copy link
Contributor

@CamilleFljt CamilleFljt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS looks good to me !

Copy link
Member

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error with E2E Test. I created the ticket of the fix

@Francois-Gomis Francois-Gomis marked this pull request as ready for review January 10, 2025 12:28
@Francois-Gomis Francois-Gomis requested a review from a team as a code owner January 10, 2025 12:28
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Francois-Gomis Francois-Gomis merged commit 36579a6 into develop Jan 13, 2025
4 of 8 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-2090-bug-block-is-not-reloaded-when-country-is-not-eligible branch January 13, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants