-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ecom 2090 bug block is not reloaded when country is not eligible #309
Feature/ecom 2090 bug block is not reloaded when country is not eligible #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS looks good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error with E2E Test. I created the ticket of the fix
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Reason for change
Linear task
Code changes
Refactor Alma client service
add BlocksDataService
Add alma_store redux store
and more ....
How to test
Test all blocks and standard gateway with and without inpage
Good Luck !
Checklist for authors and reviewers
Non applicable