Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug cart payment payload creation #200

Merged

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

Impossible to create Alma payment for new product without image

Linear task

Code changes

GetMediaUrl path must be null

How to test

Create a new product without image and order it with Alma
As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features

Non applicable

@Francois-Gomis Francois-Gomis added the bug Something isn't working label Sep 17, 2024
@Francois-Gomis Francois-Gomis requested a review from a team as a code owner September 17, 2024 07:51
@Francois-Gomis Francois-Gomis changed the base branch from main to develop September 17, 2024 07:51
@github-actions github-actions bot added the type: feature New feature label Sep 17, 2024
Copy link

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link
Contributor

@FranceBe FranceBe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Francois-Gomis Francois-Gomis merged commit b852727 into develop Sep 17, 2024
4 of 6 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-2066-ac-fix-getmedialurl-with-a-path-null branch September 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants