Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature verification on ipn #191

Merged

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

[Linear task
](https://linear.app/almapay/issue/ECOM-1819/[-ac]-add-hmac-verification-on-ipn)

Code changes

Add signature validation on IPN controller

How to test

Test with a QA instance for real signature. With the same payment test with postman without signature and with a bad signature

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces

Non applicable

  • Documentation is updated (API, developer documentation, ADR, Notion...)

@Francois-Gomis Francois-Gomis requested a review from a team as a code owner September 5, 2024 12:51
@github-actions github-actions bot added the type: feature New feature label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Sep 5, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@Francois-Gomis Francois-Gomis merged commit 2facd94 into develop Sep 10, 2024
3 of 6 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-1819-ac-add-hmac-verification-on-ipn branch September 10, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants