Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return if insurance product not exist #188

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

https://linear.app/almapay/issue/ECOM-1998/[ac]-fix-add-to-cart-without-insurance-product-in-catalog

Code changes

Change return if insurance product not exist in catalog

How to test

In ticket comment .
As a reviewer, you are encouraged to test the PR locally.

@Francois-Gomis Francois-Gomis requested a review from a team as a code owner August 14, 2024 21:53
@github-actions github-actions bot added the type: feature New feature label Aug 14, 2024
Copy link

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Copy link
Contributor

@FranceBe FranceBe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but E2E tests are failing :(

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@FranceBe FranceBe merged commit 29d565e into develop Aug 16, 2024
4 of 6 checks passed
@FranceBe FranceBe deleted the feature/ecom-1998-ac-fix-add-to-cart-without-insurance-product-in-catalog branch August 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants