Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new call to store shipping data #182

Conversation

Francois-Gomis
Copy link
Collaborator

@Francois-Gomis Francois-Gomis commented Jul 26, 2024

Reason for change

NO RELEASE BEFORE 11 AUGUST

https://linear.app/almapay/issue/ECOM-1783/[🧩-ac]-implement-new-call-to-store-shipping-data

Code changes

https://www.notion.so/almapay/Adobe-Commerce-Shipping-Tracking-Flow-dbd4110a166e473ab00a80b885da209f

How to test

Create a payment with Alma, and add a tracking

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Francois-Gomis Francois-Gomis requested a review from a team as a code owner July 26, 2024 07:25
@github-actions github-actions bot added the type: feature New feature label Jul 26, 2024

This comment has been minimized.

This comment has been minimized.

@Francois-Gomis Francois-Gomis changed the title Implement new call to store shipping data Implement new call to store shipping data - NO MERGE IN DEV PLEASE BEFORE 11 OF AUGUST Jul 26, 2024
Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

Copy link

✅ E2E tests have been successfully completed.
➡️ You can find the results here.

@Francois-Gomis Francois-Gomis changed the title Implement new call to store shipping data - NO MERGE IN DEV PLEASE BEFORE 11 OF AUGUST Implement new call to store shipping data Aug 8, 2024
@Francois-Gomis Francois-Gomis merged commit e097865 into develop Aug 8, 2024
4 of 5 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-1783-ac-implement-new-call-to-store-shipping-data branch August 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants