Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to 188c4f8 and remove temporary workarounds #55

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Apr 17, 2024

Motivation

Updates to latest version of Alloy which includes a fix for the previously reported missing .from field error that raised: Caused by: missing properties: [("NonceManager", ["from"]), ("Signer", ["TODO"])]

  • Allows us to use the simpler Contract::deploy() syntax rather than the builder.
  • Simplifies interaction pattern with contracts.
  • Cleans up artifacts and unnecessary files

PR Checklist

  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks changed the title chore: upgrade to 188c4f8 chore: upgrade to 188c4f8 and remove temporary workarounds Apr 17, 2024
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zerosnacks zerosnacks merged commit 096abf0 into main Apr 17, 2024
4 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/upgrade-to-188c4f8 branch April 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants