Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trace_call): use another address with eth balance for trace_call example #48

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(trace_call): use another address with eth balance for trace_call example #48

merged 1 commit into from
Apr 8, 2024

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Apr 8, 2024

Motivation

the trace call example from address had no eth, which was causing the test to fail.

Solution

Use an address with eth, which makes the test pass.

PR Checklist

  • Added Documentation
  • Breaking changes

@Evalir Evalir requested review from zerosnacks and yash-atreya April 8, 2024 14:10
@zerosnacks
Copy link
Member

Thanks! Closes #47

@zerosnacks zerosnacks linked an issue Apr 8, 2024 that may be closed by this pull request
Invalid transaction configuration in trace_call example #47
Closed
@zerosnacks zerosnacks merged commit e0ef555 into main Apr 8, 2024
4 checks passed
@zerosnacks zerosnacks deleted the evalir/fix-trace-example branch April 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid transaction configuration in trace_call example
2 participants
@Evalir @zerosnacks