Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): use alloy namespace imports and flatten example directories #10

Closed
wants to merge 11 commits into from

Conversation

zerosnacks
Copy link
Member

  • Replaces the individual direct crate imports with the alloy namespace one
  • Creates a flat directory structure, no more multi-crates

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm not sure we should do this,

I kinda like having individual crates for examples,
because some examples are a bit larger and include sol source files etc.

@zerosnacks
Copy link
Member Author

zerosnacks commented Mar 19, 2024

hmm, I'm not sure we should do this,

I kinda like having individual crates for examples, because some examples are a bit larger and include sol source files etc.

Personally I don't really mind the multi-crate architecture, this is a proposed solution to the request of @gakonst to get out of the multi-crate setup.

I was imagining a shared assets directory to enable easy re-use of assets (artifacts, contracts, etc..) across examples.

I think the issue of crates being difficult to navigate to will be resolved by linking them in the README and it being a one-click to any example.

That said, in practice I don't expect anyone to actually import these examples as crates in their codebase - favouring this flat directory setup.

@zerosnacks
Copy link
Member Author

Replaced by PR only covering switch to Alloy namespace: #11

@zerosnacks zerosnacks deleted the zerosnacks/flatten-imports branch March 25, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants