Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GetWeaponData implementation. #847

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Revert GetWeaponData implementation. #847

wants to merge 3 commits into from

Conversation

afwn90cj93201nixr2e1re
Copy link
Contributor

No description provided.

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

@s1lentq
82cb94a#diff-f2122483fa3656d24872b03f9266d1daL1626

Just push load diff on deleted fakemeta.cpp file, it's gonna show line.

There is too much stuff was deleted via this commit.

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

Also this one.
@Arkshine

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re marked this pull request as ready for review May 29, 2020 20:04
@Arkshine
Copy link
Member

Arkshine commented Jun 3, 2020

Please explain. Is it actually used? Maybe it has been removed intentionally?

@WPMGPRoSToTeMa thoughts on this, please?

@WPMGPRoSToTeMa
Copy link
Contributor

@Arkshine I don't see that it was implemented earlier. But it's a useful thing that I'm also missing.

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

afwn90cj93201nixr2e1re commented Jun 4, 2020

For us? Ofc. For u? Maybe, there's much thing's u can do with that, instead using some, idk, some updateclientdata hooks.

https://www.youtube.com/watch?v=cWE9Gf0N7Aw
We made this. And some another usefull stuff.

@WPMGPRoSToTeMa
Copy link
Contributor

WPMGPRoSToTeMa commented Jun 4, 2020

I already saw it, but it is only a stub, nothing related to .inc and etc stuff.

amxmodx/fakemeta.cpp is also not related to fakemeta AMXX module. The source code for the module is located in dlls/fakemeta folder.

For us? Ofc. For u? Maybe, there's much thing's u can do with that, instead using some, idk, some updateclientdata hooks.

https://www.youtube.com/watch?v=cWE9Gf0N7Aw
We made this. And some another usefull stuff.

Yep, previously I was doing this through changing m_iClip in UpdateClientData and then restoring its original value in AddToFullPack.

@Arkshine
Copy link
Member

Arkshine commented Jul 17, 2020

So, and explaining why there is index in native coz weapon_data handler is 64 array, and size of 64*weapon_data can cause stack issues, that's why i just provide pointer instead WeaponData:arr[64].

You mean 32? Isn't this structure associated to MAX_WEAPONS ; and I believe value is 32 in GoldSrc.
As minimal safety, native should throw an error is index is out of bound.

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

afwn90cj93201nixr2e1re commented Jul 17, 2020

No it's not, and no, not 32, 64.
https://github.com/dreamstalker/rehlds/search?q=weapon_data_t&type=

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

I mean i can provide into plugin public asd(WeaponData:arr[64] ...) and then use native set_wd(arr[123],..) or how it was implemented by me rn, public asd (WeaponData:arrPtr, ...) {
Set_wd(arrPtr, arrIndex (0-63), values...)

@afwn90cj93201nixr2e1re afwn90cj93201nixr2e1re marked this pull request as draft December 6, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants