Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow [i|scroll]message to include AMX Mod X vers. #565

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Allow [i|scroll]message to include AMX Mod X vers. #565

wants to merge 12 commits into from

Conversation

ClaudiuHKS
Copy link
Contributor

Allow [ i | scroll ]message to include AMX Mod X version as well.

@Arkshine
Copy link
Member

You need to update amxx.cfg in the /cstrike and /ns folders as well.

@Arkshine
Copy link
Member

Looks good know. Thanks!

@WPMGPRoSToTeMa
Copy link
Contributor

WPMGPRoSToTeMa commented Sep 11, 2018

This replacement is a bit unpredictable, imagine if hostname contains %version%.

@Arkshine
Copy link
Member

Yea, I did not merge it because I was uncertain. You get a valid point. Though not dramatic.

I was also unsure to show the version because you will now have something like "1.9.0.5200", and this would appear a little long & unnecessary. I'm okay to have %version%, but I don't think you need to specify the version in the original message.

@ClaudiuHKS
Copy link
Contributor Author

ClaudiuHKS commented Sep 12, 2018

Both 1.9.0.5200 and 1.9.0 look OK to me.
How can I format 1.9.0.5200 to 1.9.0 without sscanf, a lot of functions and variables or even a stock?

@Arkshine
Copy link
Member

Arkshine commented Sep 12, 2018

I don't know if it makes sense to provide the version in this message (as the purpose would just to tell the server uses AMXX and that's it), but you can either cut the string, like version[3] = EOS or you can use AMXX_VERSION_MAJOR + "." + AMXX_VERSION_MINOR

@ClaudiuHKS
Copy link
Contributor Author

Thanks!

@Arkshine
Copy link
Member

You can actually use directly AMXX_VERSION_MAJOR + "." + AMXX_VERSION_MINOR.
You can concatenate strings in macro now with + and you can stringize with #.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants