Add 'j' and 'k' flags in get_players for matching with admin flags

[OciXCrom]

"j" - match with all of the specified admin flags
"k" - match with any of the specified admin flags

[Mistrick]

Maybe add consts for all flags?

[rsKliPPy]

You should also update get_players_ex to match this change.

[OciXCrom]

@rsKliPPy - I honestly didn't know that function even existed. Will do it tomorrow.

[rsKliPPy]

It's alright, it's a fairly recent addition.

[OciXCrom]

@rsKliPPy - done.

[Arkshine]

You can't rename params like that. You will break backward compatibility. People can still explicit the param .team = .

[Arkshine]

I think it's okay to not update get_players anyway. We should encourage the use of flags as a string. We don't need to keep the same functionalities, after all, get_players_ex is an extended version.

[OciXCrom]

@Arkshine I changed the param name back to team. I don't think however that get_players shouldn't be updated. get_players_ex is a stock that is depending on get_players.

stock get_players_ex(players[MAX_PLAYERS], &num, GetPlayersFlags:flags = GetPlayers_None, const team[] = "")
{
	new strFlags[12];
	get_flags(_:flags, strFlags, charsmax(strFlags));
	get_players(players, num, strFlags, team);
}

If we don't update get_players, this change will have no effect.

[Arkshine]

It was fine to keep 'string' for get_players_ex, it was introduced in dev recently. If possible we should have a generic term here and actually something a bit more meaningful, maybe 'argument' or 'arg' ; don't know.

[OciXCrom]

@Arkshine In my opinion it was fine for get_players too. I doubt that anyone will use parameter skipping here since all previous parameters in the function must be written in order for the team parameter to even be used. Simply said, get_players(iPlayers, iPnum, .team = "CT") is not valid, so chances are nobody will experience problems with backwards compatibility here.

Anyways, I'll change it back to string for get_players_ex if you want. I chose the name string because the description for the param says string to match against. I couldn't figure out a more appropriate name either.

[Arkshine]

string is fine.

What do you mean by get_players(iPlayers, iPnum, .team = "CT") not being valid? It is valid.

[OciXCrom]

@Arkshine I put back string for get_players_ex.

I meant that it won't have an effect because if the "e" flag isn't specified then it won't search for the team at all so most likely people won't do that.

[WPMGPRoSToTeMa]

Arg name should also be fixed for get_playersnum_ex.
Also maybe we should replace &num argument in get_players_ex with return value?