Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting shared memory when creating training beaker job #80

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

favyen2
Copy link
Collaborator

@favyen2 favyen2 commented Dec 12, 2024

I encountered some training jobs that ran out of shared memory. So added this to default to a good amount of shared memory and also allow user to override it.

@favyen2 favyen2 requested a review from yawenzzzz January 9, 2025 19:57
Copy link
Collaborator

@yawenzzzz yawenzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@favyen2 favyen2 merged commit 8a39971 into master Jan 10, 2025
5 checks passed
@favyen2 favyen2 deleted the favyen/train-job-shared-memory branch January 10, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants