Dockerfile improvements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other issues. We should set version range in the future if we have the time to identify it, or we can keep up with latest versions.
|
Hm this one is actually failing test, I'm not sure why, it's running out of disk space, do you think the runner is too small? Just because of |
Hgherzog
approved these changes
Oct 23, 2024
(which is good since we anyway wanted to do that at some point)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--upgradewhen installing with pip. I ran into issues with s3fs since it seems to already be installed in the base image, and was outdated. In the future we can provide version range inrequirements.txtif we have time to maintain that, or we can just keep up with the latest versions of the various packages..envin Docker image.Dockerfile.devwhere requirements can be installed based on local version of rslearn.This depends on the fastapi PR.