Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add github actions workflow #40

Merged
merged 22 commits into from
Oct 17, 2024
Merged

add github actions workflow #40

merged 22 commits into from
Oct 17, 2024

Conversation

Hgherzog
Copy link
Collaborator

No description provided.

@Hgherzog Hgherzog marked this pull request as ready for review October 17, 2024 06:17
@favyen2 favyen2 self-requested a review October 17, 2024 15:06
favyen2
favyen2 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@favyen2 favyen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I tested the DockerFile with beaker and it worked (I didn't pass the arguments but it worked anyway I think because the rslearn repo is public now)

@favyen2 favyen2 merged commit 72100cb into master Oct 17, 2024
3 checks passed
@favyen2 favyen2 deleted the henryh/setup-github_actions branch October 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favyen2 favyen2 favyen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hgherzog @favyen2