Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metricstore send support #261

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Conversation

EvanLjp
Copy link
Collaborator

@EvanLjp EvanLjp commented Mar 27, 2024

支持Metricstore hash 写模式

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

client_store.go Outdated
@@ -103,6 +103,12 @@ func (c *Client) PostLogStoreLogs(project, logstore string, lg *LogGroup, hashKe
return ls.PostLogStoreLogs(lg, hashKey)
}

func (c *Client) PostMetricStoreLogs(project, logstore string, lg *LogGroup) (err error) {
ls := convertLogstore(c, project, logstore)
ls.MetricStore = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metricStore 不要暴露

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一改成useMetricStoreURL,清晰一些

log_store.go Outdated
@@ -40,6 +40,7 @@ type LogStore struct {
putLogCompressType int
EncryptConf *EncryptConf `json:"encrypt_conf,omitempty"`
ProductType string `json:"productType,omitempty"`
MetricStore bool `json:"metric_store"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json 去掉,这个不该暴露,不属于接口范围

@@ -38,6 +38,7 @@ type ProducerConfig struct {
LogTags []*sls.LogTag
GeneratePackId bool
CredentialsProvider sls.CredentialsProvider
MetricStore bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseMetricStoreURL

Copy link
Collaborator

@shabicheng shabicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvanLjp EvanLjp merged commit 7b9b95d into aliyun:master Mar 27, 2024
1 of 2 checks passed
@EvanLjp EvanLjp deleted the add-metricstore-send branch March 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants