chore: refine add benchmark

aliyun · Dec 6, 2024 · 449af35 · 449af35
1 parent d892373
commit 449af35
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/producer/pack_id.go b/producer/pack_id.go
@@ -23,7 +23,7 @@ func newPackIdGenerator() *PackIdGenerator {
 func (g *PackIdGenerator) GeneratePackId(project, logstore string) string {
 	key := project + "|" + logstore
 
-	// fast path, logstore already has a counter
+	// fast path, logstore already has a generator
 	g.mutex.RLock()
 	if l, ok := g.logstorePackIdGenerator[key]; ok {
 		packNumber := l.packNumber.Add(1)
@@ -34,12 +34,12 @@ func (g *PackIdGenerator) GeneratePackId(project, logstore string) string {
 
 	// slow path
 	g.mutex.Lock()
-	defer g.mutex.Unlock()
 	if _, ok := g.logstorePackIdGenerator[key]; !ok {
 		g.logstorePackIdGenerator[key] = newLogStorePackIdGenerator(g.count.Add(1))
 	}
 	l := g.logstorePackIdGenerator[key]
 	packNumber := l.packNumber.Add(1)
+	g.mutex.Unlock()
 	return fmt.Sprintf("%s%X", l.prefix, packNumber-1)
 }
 

diff --git a/producer/pack_id_test.go b/producer/pack_id_test.go
@@ -34,5 +34,12 @@ func TestPackIdGenerator(t *testing.T) {
 		}(i)
 	}
 	wg.Wait()
+}
 
+// BenchmarkPackIdGenerator-12    	 8366719	       120.7 ns/op	      64 B/op	       4 allocs/op
+func BenchmarkPackIdGenerator(b *testing.B) {
+	g := newPackIdGenerator()
+	for i := 0; i < b.N; i++ {
+		g.GeneratePackId("test", "test")
+	}
 }