Skip to content

Commit

Permalink
chore: update dependencies
Browse files Browse the repository at this point in the history
* update all dependencies (except compose material and material3 as they have issues on newer alphas), AGP, Kotlin, Gradle
* replace `Enum.values()` with `Enum.entries`
* replace deprecated functions
  • Loading branch information
aliernfrog committed Jan 21, 2024
1 parent f3ba8b0 commit f01f307
Show file tree
Hide file tree
Showing 23 changed files with 73 additions and 74 deletions.
15 changes: 6 additions & 9 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,9 @@ plugins {
id("org.jetbrains.kotlin.android")
}

// compose material 1.6.0-alpha08 has crashes with LazyColumn/Row
// 1.6.0-beta01 - beta02 has IME issues (focused text fields do not open keyboard when clicked)
// sticking to alpha07 (also alpha09 for material3) until these issues are fixed.
val composeMaterialVersion = "1.6.0-alpha07"
val composeMaterial3Version = "1.2.0-alpha09"
val composeCompilerVersion = "1.5.5"
val composeCompilerVersion = "1.5.8"

android {
namespace = "com.aliernfrog.lactool"
Expand Down Expand Up @@ -64,13 +61,13 @@ dependencies {
implementation("androidx.compose.material:material-icons-extended:$composeMaterialVersion")
implementation("androidx.compose.material3:material3:$composeMaterial3Version")
implementation("androidx.compose.material3:material3-window-size-class:$composeMaterial3Version")
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.6.2")
implementation("androidx.activity:activity-compose:1.8.1")
implementation("androidx.navigation:navigation-compose:2.7.5")
implementation("io.insert-koin:koin-androidx-compose:3.5.0")
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.7.0")
implementation("androidx.activity:activity-compose:1.8.2")
implementation("androidx.navigation:navigation-compose:2.7.6")
implementation("io.insert-koin:koin-androidx-compose:3.5.3")
implementation("com.github.aliernfrog:top-toast-compose:1.3.4")
implementation("com.github.aliernfrog:laclib:1.1.0")
implementation("com.lazygeniouz:dfc:1.0.8")
implementation("io.coil-kt:coil-compose:2.5.0")
implementation("com.github.jeziellago:compose-markdown:0.3.7")
implementation("com.github.jeziellago:compose-markdown:0.4.1")
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import com.aliernfrog.lactool.ui.theme.LACToolTheme
import com.aliernfrog.lactool.ui.theme.Theme
import com.aliernfrog.lactool.ui.viewmodel.MainViewModel
import com.aliernfrog.toptoast.component.TopToastHost
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

class MainActivity : ComponentActivity() {

Expand All @@ -39,7 +39,7 @@ class MainActivity : ComponentActivity() {

@Composable
private fun AppContent(
mainViewModel: MainViewModel = getViewModel()
mainViewModel: MainViewModel = koinViewModel()
) {
val view = LocalView.current
val scope = rememberCoroutineScope()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import com.aliernfrog.lactool.ui.theme.AppBottomSheetShape
import com.aliernfrog.lactool.ui.viewmodel.InsetsViewModel
import com.aliernfrog.lactool.util.extension.isAnyVisible
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class)
@Composable
Expand Down Expand Up @@ -60,7 +60,7 @@ fun AppModalBottomSheet(
@Composable
fun BaseModalBottomSheet(
sheetState: SheetState,
insetsViewModel: InsetsViewModel = getViewModel(),
insetsViewModel: InsetsViewModel = koinViewModel(),
dragHandle: @Composable (() -> Unit)? = { BottomSheetDefaults.DragHandle() },
content: @Composable ColumnScope.(bottomPadding: Dp) -> Unit
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ fun BaseScaffold(
val density = LocalDensity.current
val layoutDirection = LocalLayoutDirection.current

val destinations = remember { Destination.values().toList() }
val destinations = remember { Destination.entries.toList() }
val mainDestinations = remember { destinations.filter { it.showInNavigationBar } }
val currentRoute = navController.currentBackStackEntryAsState().value?.destination?.route
val currentDestination = destinations.find { it.route == currentRoute }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.LocalContentColor
import androidx.compose.material3.LocalTextStyle
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
Expand Down Expand Up @@ -54,8 +55,10 @@ fun FilesDowngradeNotice(
modifier = Modifier.verticalScroll(rememberScrollState()),
markdown = stringResource(R.string.permissions_filesApp_moreInfo_text)
.replace("{MORE_INFO_URL}", "https://aliernfrog.github.io/android-data-access"),
color = LocalContentColor.current,
linkColor = MaterialTheme.colorScheme.primary,
style = LocalTextStyle.current.copy(
color = LocalContentColor.current
),
onLinkClicked = {
uriHandler.openUri(it)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import androidx.compose.ui.layout.onSizeChanged
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.unit.Dp
import com.aliernfrog.lactool.ui.viewmodel.InsetsViewModel
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@Composable
fun InsetsObserver(
insetsViewModel: InsetsViewModel = getViewModel()
insetsViewModel: InsetsViewModel = koinViewModel()
) {
val density = LocalDensity.current
fun toDp(pxs: Int): Dp {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ import com.aliernfrog.lactool.util.extension.horizontalFadingEdge
import com.aliernfrog.lactool.util.extension.resolvePath
import com.aliernfrog.lactool.util.extension.takePersistablePermissions
import com.aliernfrog.lactool.util.manager.PreferenceManager
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@Composable
fun FolderConfigurationDialog(
onDismissRequest: () -> Unit,
settingsViewModel: SettingsViewModel = getViewModel()
settingsViewModel: SettingsViewModel = koinViewModel()
) {
val context = LocalContext.current
val folders = remember { SettingsConstant.folders }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ import com.aliernfrog.lactool.ui.sheet.UpdateSheet
import com.aliernfrog.lactool.ui.viewmodel.MainViewModel
import com.aliernfrog.lactool.util.Destination
import com.aliernfrog.lactool.util.NavigationConstant
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MainScreen(
mainViewModel: MainViewModel = getViewModel()
mainViewModel: MainViewModel = koinViewModel()
) {
val navController = rememberNavController()
BaseScaffold(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ import com.aliernfrog.lactool.ui.viewmodel.SettingsViewModel
import com.aliernfrog.lactool.util.staticutil.GeneralUtil
import com.aliernfrog.toptoast.enum.TopToastType
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel


@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun SettingsScreen(
mainViewModel: MainViewModel = getViewModel(),
settingsViewModel: SettingsViewModel = getViewModel()
mainViewModel: MainViewModel = koinViewModel(),
settingsViewModel: SettingsViewModel = koinViewModel()
) {
val scope = rememberCoroutineScope()
AppScaffold(
Expand Down Expand Up @@ -78,7 +78,7 @@ fun SettingsScreen(

@Composable
private fun AppearanceOptions(
settingsViewModel: SettingsViewModel = getViewModel()
settingsViewModel: SettingsViewModel = koinViewModel()
) {
val themeOptions = listOf(
stringResource(R.string.settings_appearance_theme_system),
Expand Down Expand Up @@ -113,7 +113,7 @@ private fun AppearanceOptions(

@Composable
private fun GeneralOptions(
settingsViewModel: SettingsViewModel = getViewModel()
settingsViewModel: SettingsViewModel = koinViewModel()
) {
FormSection(title = stringResource(R.string.settings_general)) {
SwitchRow(
Expand Down Expand Up @@ -145,8 +145,8 @@ private fun GeneralOptions(
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun AboutApp(
mainViewModel: MainViewModel = getViewModel(),
settingsViewModel: SettingsViewModel = getViewModel()
mainViewModel: MainViewModel = koinViewModel(),
settingsViewModel: SettingsViewModel = koinViewModel()
) {
val scope = rememberCoroutineScope()
val version = "${mainViewModel.applicationVersionName} (${mainViewModel.applicationVersionCode})"
Expand Down Expand Up @@ -215,8 +215,8 @@ private fun Links(
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun ExperimentalSettings(
mainViewModel: MainViewModel = getViewModel(),
settingsViewModel: SettingsViewModel = getViewModel()
mainViewModel: MainViewModel = koinViewModel(),
settingsViewModel: SettingsViewModel = koinViewModel()
) {
val context = LocalContext.current
val scope = rememberCoroutineScope()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ import com.aliernfrog.lactool.ui.viewmodel.MapsEditViewModel
import com.aliernfrog.lactool.util.Destination
import com.aliernfrog.lactool.util.extension.getName
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MapsEditScreen(
mapsEditViewModel: MapsEditViewModel = getViewModel(),
mapsEditViewModel: MapsEditViewModel = koinViewModel(),
onNavigateBackRequest: () -> Unit,
onNavigateRequest: (Destination) -> Unit
) {
Expand Down Expand Up @@ -92,7 +92,7 @@ fun MapsEditScreen(

@Composable
private fun GeneralActions(
mapsEditViewModel: MapsEditViewModel = getViewModel(),
mapsEditViewModel: MapsEditViewModel = koinViewModel(),
onNavigateRequest: (Destination) -> Unit
) {
FormSection(title = stringResource(R.string.mapsEdit_general), bottomDivider = false) {
Expand All @@ -113,10 +113,10 @@ private fun GeneralActions(
}
) {
RadioButtons(
options = LACMapType.values().map { it.getName() },
options = LACMapType.entries.map { it.getName() },
selectedOptionIndex = (mapsEditViewModel.mapEditor?.mapType ?: LACMapType.WHITE_GRID).index,
contentColor = MaterialTheme.colorScheme.onSurfaceVariant,
onSelect = { mapsEditViewModel.setMapType(LACMapType.values()[it]) }
onSelect = { mapsEditViewModel.setMapType(LACMapType.entries[it]) }
)
}
}
Expand Down Expand Up @@ -147,7 +147,7 @@ private fun GeneralActions(

@Composable
private fun OptionsActions(
mapsEditViewModel: MapsEditViewModel = getViewModel()
mapsEditViewModel: MapsEditViewModel = koinViewModel()
) {
FadeVisibilityColumn(visible = !mapsEditViewModel.mapEditor?.mapOptions.isNullOrEmpty()) {
FormSection(title = stringResource(R.string.mapsEdit_options), topDivider = true, bottomDivider = false) {
Expand Down Expand Up @@ -187,7 +187,7 @@ private fun OptionsActions(

@Composable
private fun MiscActions(
mapsEditViewModel: MapsEditViewModel = getViewModel()
mapsEditViewModel: MapsEditViewModel = koinViewModel()
) {
val context = LocalContext.current
FormSection(title = stringResource(R.string.mapsEdit_misc), topDivider = true, bottomDivider = false) {
Expand Down Expand Up @@ -218,7 +218,7 @@ private fun MiscActions(

@Composable
private fun FilterObjects(
mapsEditViewModel: MapsEditViewModel = getViewModel()
mapsEditViewModel: MapsEditViewModel = koinViewModel()
) {
val context = LocalContext.current
val matches = mapsEditViewModel.getObjectFilterMatches().size
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ import com.aliernfrog.toptoast.enum.TopToastColor
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class, ExperimentalFoundationApi::class)
@Composable
fun MapsListScreen(
mapsListViewModel: MapsListViewModel = getViewModel(),
mapsViewModel: MapsViewModel = getViewModel(),
mapsListViewModel: MapsListViewModel = koinViewModel(),
mapsViewModel: MapsViewModel = koinViewModel(),
title: String = stringResource(R.string.mapsList_pickMap),
onBackClick: (() -> Unit)?,
onMapPick: (Any) -> Unit
Expand Down Expand Up @@ -253,7 +253,7 @@ private fun Search(
modifier = Modifier.padding(horizontal = 10.dp)
)
DividerRow(Modifier.padding(vertical = 4.dp))
MapsListSortingType.values().forEach { option ->
MapsListSortingType.entries.forEach { option ->
DropdownMenuItem(
text = { Text(stringResource(option.labelId)) },
leadingIcon = {
Expand Down Expand Up @@ -310,14 +310,14 @@ private fun Filter(
onSelectedSegmentChange: (MapsListSegment) -> Unit
) {
SegmentedButtons(
options = MapsListSegment.values().map {
options = MapsListSegment.entries.map {
stringResource(it.labelId)
},
selectedIndex = selectedSegment.ordinal,
modifier = Modifier
.fillMaxWidth()
.padding(8.dp)
) {
onSelectedSegmentChange(MapsListSegment.values()[it])
onSelectedSegmentChange(MapsListSegment.entries[it])
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ import com.aliernfrog.lactool.ui.dialog.MaterialsNoConnectionDialog
import com.aliernfrog.lactool.ui.sheet.DownloadableMaterialSheet
import com.aliernfrog.lactool.ui.viewmodel.MapsEditViewModel
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MapsMaterialsScreen(
mapsEditViewModel: MapsEditViewModel = getViewModel(),
mapsEditViewModel: MapsEditViewModel = koinViewModel(),
onNavigateBackRequest: () -> Unit
) {
val context = LocalContext.current
Expand Down Expand Up @@ -124,7 +124,7 @@ fun MapsMaterialsScreen(

@Composable
private fun Suggestions(
mapsEditViewModel: MapsEditViewModel = getViewModel()
mapsEditViewModel: MapsEditViewModel = koinViewModel()
) {
val scope = rememberCoroutineScope()
val unusedMaterials = mapsEditViewModel.mapEditor?.downloadableMaterials?.filter { it.usedBy.isEmpty() } ?: listOf()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ import com.aliernfrog.lactool.ui.component.maps.MapToMerge
import com.aliernfrog.lactool.ui.dialog.MergeMapDialog
import com.aliernfrog.lactool.ui.viewmodel.MapsMergeViewModel
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@Composable
fun MapsMergeScreen(
mapsMergeViewModel: MapsMergeViewModel = getViewModel(),
mapsMergeViewModel: MapsMergeViewModel = koinViewModel(),
onNavigateBackRequest: () -> Unit
) {
val context = LocalContext.current
Expand All @@ -66,7 +66,7 @@ fun MapsMergeScreen(
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun MergeScreen(
mapsMergeViewModel: MapsMergeViewModel = getViewModel(),
mapsMergeViewModel: MapsMergeViewModel = koinViewModel(),
onNavigateBackRequest: () -> Unit
) {
val context = LocalContext.current
Expand Down Expand Up @@ -168,7 +168,7 @@ private fun PickMapButton(

@Composable
private fun MapButtonWithActions(
mapsMergeViewModel: MapsMergeViewModel = getViewModel(),
mapsMergeViewModel: MapsMergeViewModel = koinViewModel(),
mapToMerge: LACMapToMerge,
mapIndex: Int,
containerColor: Color = MaterialTheme.colorScheme.surfaceVariant
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import com.aliernfrog.lactool.data.PermissionData
import com.aliernfrog.lactool.ui.screen.PermissionsScreen
import com.aliernfrog.lactool.ui.viewmodel.MapsViewModel
import com.aliernfrog.lactool.util.Destination
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@Composable
fun MapsPermissionsScreen(
onNavigateRequest: (Destination) -> Unit,
mapsViewModel: MapsViewModel = getViewModel()
mapsViewModel: MapsViewModel = koinViewModel()
) {
val permissions = remember { arrayOf(
PermissionData(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ import com.aliernfrog.lactool.ui.sheet.AddRoleSheet
import com.aliernfrog.lactool.ui.viewmodel.MapsEditViewModel
import com.aliernfrog.lactool.util.extension.removeHtml
import kotlinx.coroutines.launch
import org.koin.androidx.compose.getViewModel
import org.koin.androidx.compose.koinViewModel

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MapsRolesScreen(
mapsEditViewModel: MapsEditViewModel = getViewModel(),
mapsEditViewModel: MapsEditViewModel = koinViewModel(),
onNavigateBackRequest: () -> Unit
) {
val context = LocalContext.current
Expand Down
Loading

0 comments on commit f01f307

Please sign in to comment.